feat(new-trace): Added logic for red errored rows. #66194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Abdkhan14
commented
Mar 4, 2024
Abdkhan14
commented
github-actions
bot
added
the
Scope: Frontend
JonasBa
reviewed
Mar 4, 2024
| @@ -1219,6 +1221,24 @@ export class ParentAutogroupNode extends TraceTreeNode<TraceTree.ChildrenAutogro | |||
| } | |||
| return this.tail.children; | |||
| } | |||
|
|
|||
| get errored(): boolean { | |||
There was a problem hiding this comment.
has_error since this property is static, we should cache it avoid iterating the entire tree. I would probably go with having a TraceTreeNode[] property on the autogrouped node where we push the errored references at the time of autogrouping. This also gives us the ability to show to the user all errors or use that list to iterate and show 🔥 icons.
There was a problem hiding this comment.
Great idea @JonasBa , I'll move forward with this.
JonasBa
approved these changes
Mar 4, 2024
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
<img width="1035" alt="Screenshot 2024-03-03 at 9 36 22 PM" src="https://github.com/getsentry/sentry/assets/60121741/860a6370-b1aa-41dc-b5c8-b62b9778ffa5"> --------- Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.