Clean up ArtifactBundle(FlatFile)Index, step 3
#66208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- Raw SQL operation
--
DROP TABLE "sentry_artifactbundleflatfileindex";
--
-- Raw SQL operation
--
DROP TABLE "sentry_flatfileindexstate";
--
-- Raw SQL operation
--
ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "release_name";
ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "dist_name";
ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "date_last_modified"; |
Swatinem
force-pushed
the
swatinem/abi-cleanup-step3
branch
from
bce9612
to
6f57d2c
Compare
Swatinem
force-pushed
the
swatinem/abi-cleanup-step2
branch
from
48ca11b
to
6079046
Compare
iambriccardo
approved these changes
Mar 4, 2024
Swatinem
force-pushed
the
swatinem/abi-cleanup-step2
branch
2 times, most recently
from
2afd2c3
to
164e231
Compare
Swatinem
force-pushed
the
swatinem/abi-cleanup-step3
branch
from
6f57d2c
to
48c9124
Compare
|
This PR has a migration; here is the generated SQL for --
-- Raw SQL operation
--
DROP TABLE "sentry_artifactbundleflatfileindex";
--
-- Raw SQL operation
--
DROP TABLE "sentry_flatfileindexstate";
--
-- Raw SQL operation
--
ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "release_name";
ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "dist_name";
ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "date_last_modified"; |
markstory
approved these changes
Mar 5, 2024
| operations = [ | ||
| migrations.RunSQL( | ||
| """ | ||
| DROP TABLE "sentry_artifactbundleflatfileindex"; |
There was a problem hiding this comment.
There aren't any references to this model or table in the application code anymore 👍
Comment on lines
44
to
46
| ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "release_name"; | ||
| ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "dist_name"; | ||
| ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "date_last_modified"; |
There was a problem hiding this comment.
These columns don't exist in the model definition currently 👍
In step 3, we fully drop the obsolete columns and tables after they have been removed from the migration state in prior steps.
Swatinem
force-pushed
the
swatinem/abi-cleanup-step3
branch
from
48c9124
to
c472247
Compare
|
This PR has a migration; here is the generated SQL for --
-- Raw SQL operation
--
DROP TABLE "sentry_artifactbundleflatfileindex";
--
-- Raw SQL operation
--
DROP TABLE "sentry_flatfileindexstate";
--
-- Raw SQL operation
--
ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "release_name";
ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "dist_name";
ALTER TABLE "sentry_artifactbundleindex" DROP COLUMN "date_last_modified"; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66208 +/- ##
=======================================
Coverage 84.29% 84.29%
=======================================
Files 5309 5309
Lines 237222 237222
Branches 41038 41038
=======================================
Hits 199974 199974
Misses 37029 37029
Partials 219 219 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third step, following #66206 and #66207:
In step 3, we fully drop the obsolete columns and tables after they have been removed from the migration state in prior steps.