Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autofix): timeout with autofix, query state #66241

Merged
merged 6 commits into from Mar 4, 2024
Merged

feat(autofix): timeout with autofix, query state #66241

merged 6 commits into from Mar 4, 2024

Conversation

corps
Copy link
Member

@corps corps commented Mar 4, 2024

No description provided.

@corps corps requested a review from jennmueng March 4, 2024 19:43
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 4, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.29%. Comparing base (7d8cc02) to head (cc548a1).
Report is 19 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #66241      +/-   ##
==========================================
+ Coverage   84.27%   84.29%   +0.01%     
==========================================
  Files        5304     5304              
  Lines      236999   237063      +64     
  Branches    41024    41028       +4     
==========================================
+ Hits       199728   199827      +99     
+ Misses      37052    37017      -35     
  Partials      219      219
Files Coverage Δ
src/sentry/api/endpoints/group_ai_autofix.py 89.88% <ø> (ø)
src/sentry/api/endpoints/seer_rpc.py 80.83% <88.88%> (+41.61%) ⬆️

... and 12 files with indirect coverage changes

jennmueng
jennmueng approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@jennmueng jennmueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corps corps merged commit c719749 into master Mar 4, 2024
48 of 49 checks passed
@corps corps deleted the zc/autofix-timeout-and-fetch-state branch March 4, 2024 22:25
aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024
@corps @aliu3ntry
feat(autofix): timeout with autofix, query state (#66241)
35a45b3
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jennmueng jennmueng jennmueng approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@corps @jennmueng