Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(dynamic-sampling): Remove capture message for timing #66245

Merged
merged 1 commit into from Mar 5, 2024
Merged

ref(dynamic-sampling): Remove capture message for timing #66245

merged 1 commit into from Mar 5, 2024

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Mar 4, 2024 •
edited

This PR removes the capture_message usage of the dynamic sampling context decorator.

Closes: #55544

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 4, 2024
@iambriccardo iambriccardo marked this pull request as ready for review March 4, 2024 20:10
@iambriccardo iambriccardo requested a review from a team as a code owner March 4, 2024 20:10
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.27%. Comparing base (7d8cc02) to head (84a6674).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #66245   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files        5304     5304           
  Lines      236999   236995    -4     
  Branches    41024    41024           
=======================================
+ Hits       199728   199729    +1     
+ Misses      37052    37047    -5     
  Partials      219      219
Files Coverage Δ
src/sentry/dynamic_sampling/tasks/utils.py 97.43% <ø> (-0.24%) ⬇️

... and 4 files with indirect coverage changes

@iambriccardo iambriccardo merged commit 3dca5d5 into master Mar 5, 2024
51 checks passed
@iambriccardo iambriccardo deleted the riccardo/fix/remove-capture-message branch March 5, 2024 07:46
aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024
@iambriccardo @aliu3ntry
ref(dynamic-sampling): Remove capture message for timing (#66245)
05b4d67
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ArthurKnaus ArthurKnaus ArthurKnaus approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic sampling tasks produce a lot of issues in sentry internal project
2 participants
@iambriccardo @ArthurKnaus