feat(performance): Updates useIndexedSpans to accept an optional fields array #66275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
|
Reusing this hook for INP span samples and I want to be able to selectively choose fields. |
gggritso
reviewed
Mar 5, 2024
edwardgou-sentry
commented
Mar 5, 2024
Comment on lines
+25
to
+27
| // TODO: we're using all SpanIndexedFields here, but maybe we should only use what we need? | ||
| // Truncate to 20 fields otherwise discover will complain. | ||
| const fields = Object.values(SpanIndexedField).slice(0, 20); |
There was a problem hiding this comment.
Added a todo note here. We need to update this because SpanIndexedField is eventually going to grow beyond 20 elements and Discover doesn't support querying more than 20.
There was a problem hiding this comment.
Up to you, but IMO it's fine to let Discover complain, rather than truncating the fields, since that's a silent failure! Anyone who doesn't know about the limit would be really confused why fields they're asking for aren't coming back, and everyone should provide the list of fields they want, rather than defaulting to all fields coming back
gggritso
approved these changes
Mar 5, 2024
edwardgou-sentry
deleted the
egou/feat/allow-field-selection-on-indexed-spans
branch
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
…ds array (#66275) Updates useIndexedSpans to accept an optional fields array to allow selecting specific fields. Refactors existing call to use new function signature.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates useIndexedSpans to accept an optional fields array to allow selecting specific fields.
Refactors existing call to use new function signature.