Remove FileBlob locking entirely
#66297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a Redis-based lock to protect concurrent `FileBlob` uploads and deletes, the code was already changed previously to handle the cases of concurrent uploads, as well as to reduce the likelihood of concurrent deletes by regularly bumping the `FileBlob` timestamp. The lock has been disabled via an `option` recently, and now it is time to completely remove this code.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #66297 +/- ##
==========================================
- Coverage 84.29% 84.29% -0.01%
==========================================
Files 5306 5306
Lines 237095 237013 -82
Branches 41029 41014 -15
==========================================
- Hits 199859 199781 -78
+ Misses 37017 37013 -4
Partials 219 219
|
anonrig
approved these changes
Mar 5, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
Instead of using a Redis-based lock to protect concurrent `FileBlob` uploads and deletes, the code was already changed previously to handle the cases of concurrent uploads, as well as to reduce the likelihood of concurrent deletes by regularly bumping the `FileBlob` timestamp. The lock has been disabled via an `option` recently, and now it is time to completely remove this code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a Redis-based lock to protect concurrent
FileBlobuploads and deletes, the code was already changed previously to handle the cases of concurrent uploads, as well as to reduce the likelihood of concurrent deletes by regularly bumping theFileBlobtimestamp.The lock has been disabled via an
optionrecently, and now it is time to completely remove this code.