feat(profiling): pass internal (profile-scoped) dsn for function metrics ingestion to vroom #66300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
jjbayer
reviewed
Mar 5, 2024
jjbayer
reviewed
Mar 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #66300 +/- ##
==========================================
- Coverage 84.29% 84.29% -0.01%
==========================================
Files 5309 5309
Lines 237222 237235 +13
Branches 41038 41041 +3
==========================================
+ Hits 199972 199982 +10
- Misses 37031 37034 +3
Partials 219 219
|
jjbayer
approved these changes
Mar 5, 2024
JoshFerge
reviewed
Mar 6, 2024
…ofiling-metrics-dsn
Zylphrex
approved these changes
Mar 6, 2024
Comment on lines
+141
to
+145
| if options.get( | ||
| "profiling.generic_metrics.functions_ingestion.enabled" | ||
| ) and project.organization_id in options.get( | ||
| "profiling.generic_metrics.functions_ingestion.allowed_org_ids" | ||
| ): |
There was a problem hiding this comment.
As discussed, we should move this to a feature flag using the options backed rollout handler for a more incremental rollout.
But for initial testing, this is fine 👍
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
…ics ingestion to vroom (#66300)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.