feat(spans): Tag perf problems created from standalone spans #66325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
k-fish
reviewed
Mar 5, 2024
| @@ -85,7 +85,7 @@ def repeating_span(): | |||
|
|
|||
| assert ( | |||
| job["performance_problems"][0].fingerprint | |||
| == "1-GroupType.PERFORMANCE_N_PLUS_ONE_DB_QUERIES-f906d576ffde8f005fd741f7b9c8a35062361e67" | |||
| == "1-GroupType.PERFORMANCE_N_PLUS_ONE_DB_QUERIES-f906d576ffde8f005fd741f7b9c8a35062361e67-1019" | |||
There was a problem hiding this comment.
lol @ GroupType.PERFORMANCE_N_PLUS_ONE_DB_QUERIES
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66325 +/- ##
==========================================
+ Coverage 84.24% 84.29% +0.04%
==========================================
Files 5294 5309 +15
Lines 236582 237228 +646
Branches 40962 41034 +72
==========================================
+ Hits 199317 199965 +648
+ Misses 37046 37044 -2
Partials 219 219
|
This is just temporary as we test the pipeline, I want to collect some metrics so we are reasonably confident we're not introducing a ton of new fingerprints and catching more or less the same issues |
shruthilayaj
changed the title
k-fish
approved these changes
Mar 6, 2024
shruthilayaj
deleted the
shruthi/feat/update-fingerprint-and-track-metric
branch
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
As we set up the application logic to run performance issue detection on standalone spans, we want to collect metrics to check if transaction based and span based perf issue detection are equivalent. Tagging metrics with `is_standalone_spans` to track this. This also updates fingerprint so the standalone span occurrences don't get grouped with existing perf issues during testing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we set up the application logic to run performance issue detection
on standalone spans, we want to collect metrics to check if transaction
based and span based perf issue detection are equivalent. Tagging
metrics with
is_standalone_spansto track this.This also updates fingerprint so the standalone span occurrences
don't get grouped with existing perf issues during testing.