Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(commit-context): Remove unused feature flag #66345

Merged
merged 1 commit into from Mar 5, 2024

Conversation

leeandher
Copy link
Member

With #65346 and https://github.com/getsentry/getsentry/pull/12983 merged, self-hosted and all organizations on SaaS now have access to the commit-context feature for suspect commits. The feature flag can be safely removed.

@leeandher leeandher requested a review from a team as a code owner March 5, 2024 19:29
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (f9c2ffd) to head (fb61f5c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #66345   +/-   ##
=======================================
  Coverage   84.30%   84.30%           
=======================================
  Files        5309     5309           
  Lines      237200   237200           
  Branches    41035    41035           
=======================================
+ Hits       199960   199963    +3     
+ Misses      37021    37018    -3     
  Partials      219      219           
Files Coverage Δ
src/sentry/conf/server.py 90.12% <ø> (ø)
src/sentry/features/permanent.py 100.00% <ø> (ø)
src/sentry/tasks/post_process.py 91.60% <100.00%> (ø)

... and 8 files with indirect coverage changes

@leeandher leeandher merged commit 3c69753 into master Mar 5, 2024
50 checks passed
@leeandher leeandher deleted the leander/rm-commit-context branch March 5, 2024 20:05
Copy link

sentry-io bot commented Mar 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AssertionError: b'{"detail":"Event not found"}' pytest.runtest.protocol tests/sentry/api/endpoi... View Issue

Did you find this useful? React with a 👍 or 👎

aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024
With #65346 and
getsentry/getsentry#12983 merged, self-hosted
and all organizations on SaaS now have access to the commit-context
feature for suspect commits. The feature flag can be safely removed.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants