fix(hybridcloud) Add logging for bad RPC requests #66357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logging when we have a bad request from an RPC method. We don't often get sentry errors from these failures, and not being able to see the response of these operations makes debugging harder.
github-actions
bot
added
the
Scope: Backend
dashed
approved these changes
Mar 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66357 +/- ##
==========================================
- Coverage 84.29% 84.28% -0.02%
==========================================
Files 5309 5309
Lines 237211 237212 +1
Branches 41037 41037
==========================================
- Hits 199965 199938 -27
- Misses 37027 37055 +28
Partials 219 219
|
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
Add logging when we have a bad request from an RPC method. We don't often get sentry errors from these failures, and not being able to see the response of these operations makes debugging harder.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logging when we have a bad request from an RPC method. We don't often get sentry errors from these failures, and not being able to see the response of these operations makes debugging harder.