chore(superuser): Add loggers to _needs_validation #66364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
schew2381
force-pushed
the
seiji/chore/add-superuser-loggers
branch
from
b9a14e4
to
5cc92d1
Compare
schew2381
force-pushed
the
seiji/chore/add-superuser-loggers
branch
from
5cc92d1
to
64f7a03
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66364 +/- ##
==========================================
- Coverage 84.29% 84.29% -0.01%
==========================================
Files 5309 5309
Lines 237200 237198 -2
Branches 41038 41038
==========================================
- Hits 199957 199951 -6
- Misses 37024 37028 +4
Partials 219 219
|
schew2381
commented
Mar 5, 2024
Comment on lines
-36
to
-38
| DISABLE_SU_FORM_U2F_CHECK_FOR_LOCAL = getattr( | ||
| settings, "DISABLE_SU_FORM_U2F_CHECK_FOR_LOCAL", False | ||
| ) |
There was a problem hiding this comment.
Forgot to remove this in an earlier PR b/c we no longer use this in this file
There was a problem hiding this comment.
do we need to remove it from https://github.com/getsentry/sentry/pull/66364/files#diff-dcd4801baa22c78923c11bf52c23caa202d80d2990d78b0500507f78d9950c95R71 as well?
There was a problem hiding this comment.
no I changed it recently so we use it in that file, which is what i'm debugging now
nhsiehgit
approved these changes
Mar 6, 2024
| @@ -191,7 +191,7 @@ def test_su_access_logs(self, logger): | |||
| superuser = Superuser(request, org_id=None) | |||
| superuser.set_logged_in(request.user) | |||
| assert superuser.is_active is True | |||
| assert logger.info.call_count == 2 | |||
| assert logger.info.call_count == 3 | |||
There was a problem hiding this comment.
🤷 personally don't think we need to assert logger calls at all
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
There's a bug where we're no longer requiring superuser access category and reason validation, which is caused by https://github.com/getsentry/sentry/pull/66043/files. I want to validate what those booleans are in order to find out if this is the cause of the bug.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug where we're no longer requiring superuser access category and reason validation, which is caused by https://github.com/getsentry/sentry/pull/66043/files.
I want to validate what those booleans are in order to find out if this is the cause of the bug.