Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(daily summary): Add logger when sending summary #66369

Merged
merged 1 commit into from Mar 5, 2024

Conversation

ceorourke
Copy link
Member

Add a log line when we send the notification as I'm doing internal testing.

@ceorourke ceorourke requested a review from a team March 5, 2024 22:22
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.48%. Comparing base (28c907c) to head (6df5cbc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #66369      +/-   ##
==========================================
+ Coverage   81.99%   83.48%   +1.49%     
==========================================
  Files        5308     5309       +1     
  Lines      237057   237191     +134     
  Branches    41012    41038      +26     
==========================================
+ Hits       194380   198030    +3650     
+ Misses      42456    38942    -3514     
+ Partials      221      219       -2     
Files Coverage Δ
src/sentry/tasks/summaries/daily_summary.py 97.95% <100.00%> (+0.01%) ⬆️

... and 563 files with indirect coverage changes

@ceorourke ceorourke merged commit ab89d45 into master Mar 5, 2024
50 checks passed
@ceorourke ceorourke deleted the ceorourke/daily-summary-log-send branch March 5, 2024 22:52
aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024
Add a log line when we send the notification as I'm doing internal
testing.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants