Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crons): Return a better message from deprecated crons ingest apis #66388

Merged
merged 1 commit into from Mar 6, 2024

Conversation

wedamija
Copy link
Member

@wedamija wedamija commented Mar 6, 2024

No description provided.

@wedamija wedamija requested a review from a team as a code owner March 6, 2024 00:25
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.06%. Comparing base (f53fbe1) to head (b7bb7f4).
Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #66388      +/-   ##
==========================================
- Coverage   84.30%   83.06%   -1.24%     
==========================================
  Files        5309     5309              
  Lines      237185   237209      +24     
  Branches    41033    41040       +7     
==========================================
- Hits       199948   197049    -2899     
- Misses      37018    39940    +2922     
- Partials      219      220       +1     
Files Coverage Δ
src/sentry/monitors/endpoints/base.py 86.87% <100.00%> (+0.08%) ⬆️
...nitors/endpoints/monitor_ingest_checkin_details.py 90.32% <50.00%> (ø)
...monitors/endpoints/monitor_ingest_checkin_index.py 95.09% <50.00%> (ø)

... and 269 files with indirect coverage changes

@wedamija wedamija merged commit 2fcdcff into master Mar 6, 2024
49 of 50 checks passed
@wedamija wedamija deleted the danf/crons-better-deprecated-message branch March 6, 2024 00:57
aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants