ref(deps): Bump sentry-relay to v0.8.48 #66401
Conversation
github-actions
bot
added
the
Scope: Backend
src/sentry/eventstore/models.py
Outdated
| user = self.get_interface("user") | ||
| if user is not None: | ||
| user._data.pop("sentry_user", None) | ||
| return user |
There was a problem hiding this comment.
Fixes the test tests/sentry/eventstore/test_models.py::EventTest::test_snuba_data.
get_minimal_user intends to extract the minimal user that may be exposed to external services, so there's no reason to expose sentry_user. Alternatively, we could expose the value from Snuba, but I see no reason to do that as the field was originally added for DDM.
There was a problem hiding this comment.
As discussed, let's not change this function and fix the test assertion to compare a fixed set of fields instead.
There was a problem hiding this comment.
Done in 071238f.
src/sentry/receivers/features.py
Outdated
| @@ -122,7 +122,7 @@ def record_event_processed(project, event, **kwargs): | |||
| # Check to make sure more the ip address is being sent. | |||
| # testing for this in test_no_user_tracking_for_ip_address_only | |||
| # list(d.keys()) pattern is to make this python3 safe | |||
| if user_context and list(user_context.keys()) != ["ip_address"]: | |||
| if user_context and list(user_context.keys()) != ["ip_address", "sentry_user"]: | |||
There was a problem hiding this comment.
Fixes the test test_no_user_tracking_for_ip_address_only.
Relay now extracts sentry_user automatically from the IP address, and both should be filtered out together and not trigger user tracking.
| @@ -42,7 +42,7 @@ def test_interface_is_relabeled(): | |||
| manager.normalize() | |||
| data = manager.get_data() | |||
|
|
|||
| assert data["user"] == {"id": "1"} | |||
| assert data["user"] == {"id": "1", "sentry_user": "id:1"} | |||
There was a problem hiding this comment.
sentry_user is now automatically added in Relay.
| source: tests/sentry/event_manager/interfaces/test_spans.py | ||
| --- | ||
| errors: null | ||
| to_json: | ||
| - data: | ||
| http.response.status_code: 200 |
There was a problem hiding this comment.
Relay renamed the value for this key. It seems it didn't have a negative impact in other places. (same for the snapshot below)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66401 +/- ##
=======================================
Coverage 84.29% 84.29%
=======================================
Files 5309 5309
Lines 237222 237222
Branches 41038 41038
=======================================
+ Hits 199974 199975 +1
+ Misses 37029 37028 -1
Partials 219 219
|
src/sentry/eventstore/models.py
Outdated
| user = self.get_interface("user") | ||
| if user is not None: | ||
| user._data.pop("sentry_user", None) | ||
| return user |
There was a problem hiding this comment.
As discussed, let's not change this function and fix the test assertion to compare a fixed set of fields instead.
Along the way of bumping dependencies, some tests are fixed to cover for the changes in Relay.
Along the way of bumping dependencies, some tests are fixed to cover for the changes in Relay.