ref(onboarding): refactor useCurrentProjectState to be generalized #66425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ArthurKnaus
approved these changes
Mar 6, 2024
aliu3ntry
pushed a commit
that referenced
this pull request
Mar 6, 2024
…66425) - had to revert the original PR (#66118) due to a failing test - fixed in this PR! this is the only change from the previous PR - DDM, Replays, and Feedback onboarding were all using some variation of this hook: `useCurrentProjectState`. They're all pretty similar, so I refactored them into one general reusable hook - I modified the respective `sidebar.tsx` files to use this new hook - I also added a hook test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useCurrentProjectState. They're all pretty similar, so I refactored them into one general reusable hooksidebar.tsxfiles to use this new hook