Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loader): Enable INP by default #66873

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 13, 2024

Sets enableInp: true for browser tracing integration.

We also flip the conditionals so we look for the function based integrations first, since enableInp is only supported for that.

Tested with getsentry/sentry-javascript#11081

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Mar 13, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.23%. Comparing base (05e6601) to head (3e154b8).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #66873      +/-   ##
==========================================
- Coverage   84.31%   84.23%   -0.08%     
==========================================
  Files        5308     5308              
  Lines      237299   237299              
  Branches    41039    41039              
==========================================
- Hits       200070   199890     -180     
- Misses      37011    37191     +180     
  Partials      218      218              

see 30 files with indirect coverage changes

AbhiPrasad added a commit to getsentry/sentry-javascript that referenced this pull request Mar 13, 2024
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 13, 2024 16:57
@AbhiPrasad AbhiPrasad merged commit 21bbc3c into master Mar 13, 2024
54 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-enable-inp-loader-default branch March 13, 2024 16:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants