feat(integrations): custom pagerduty + opsgenie metric alert priorities FE

[cathteng]

Completes custom metric alert priority work for Pagerduty and Opsgenie. The (feature flagged) frontend allows for settings these values, and defaults to the original logic:

• Pagerduty: critical status => critical severity, warning => warning severity
• Opsgenie: critical status => P1 priority, warning => P2 priority

Screen.Recording.2024-03-13.at.14.51.31.mov

Note that we don't show the priority in the description of the action unless it has been explicitly set to something.

For #58830
For #54921

[cathteng]

these are placeholders. maybe we should prefix them with severity for Pagerduty or priority for Opsgenie

[cathteng]

default pagerduty severities:

sentry/src/sentry/integrations/pagerduty/utils.py

Lines 100 to 106 in f035e4e

	severity = "info"
	if new_status == IncidentStatus.CRITICAL:
	severity = "critical"
	elif new_status == IncidentStatus.WARNING:
	severity = "warning"
	elif new_status == IncidentStatus.CLOSED:
	severity = "info"

default opsgenie priorities:

sentry/src/sentry/integrations/opsgenie/utils.py

Lines 34 to 36 in f035e4e

	priority = "P1"
	if new_status == IncidentStatus.WARNING:
	priority = "P2"

[saponifi3d]

generally LGTM - comments are mostly just nitpicks / minor improvements to the TS :)

[saponifi3d]

nit: might be nice to make this a const before the render, for readability for the html

const isSelectEnabled = hasPriorityFlag &&  availableAction &&
  (availableAction.type === 'opsgenie' || availableAction.type === 'pagerduty');

...

{isSelectEnabled && <SelectControl .... />}

[saponifi3d]

nit: no need to add null here

Suggested change

	) : null}
	)}

[saponifi3d]

Suggested change

	export const PriorityOptions = {
	export const PriorityOptions: Record<ActionType, string[]> = {

[saponifi3d]

might be nice to move these priorities to an enum rather than a inlining them

export enum PagerDutyPriorities {
  CRITICAL = 'critical',
  WARNING = 'warning',
  ERROR = 'error',
  INFO = 'info',
};

export enum OpsGeniePriorities {
  P1: 'P1',
  P2: 'P2',
  ...
}

This is also nice since you're using these strings later in DefaultPriories too.

export const DefaultPriorities = {
  [ActionType.PAGERDUTY]: {[0]: PagerDutyPriorities.CRITICAL, [1]: PagerDutyPriorities.WARNING},
  [ActionType.OPSGENIE]: {[0]:  OpsGeniePriorties.P1, [1]: OpsGeniePriorties.P2},
};

[saponifi3d]

Suggested change

	(availableAction.type === 'opsgenie' ||
	availableAction.type === 'pagerduty') ? (
	(availableAction.type === 'opsgenie' ||
	availableAction.type === 'pagerduty') ? (

also suggest moving these opsgenie and pagerduty to constants at the top of the file:

const OPSGENIE = 'opsgenie';
const PAGERDUTY = 'pagerduty';

[saponifi3d]

I'd recommend adding some typing to this, then changing the data structure from an object to an array.

Suggested change

	export const DefaultPriorities = {
	[ActionType.PAGERDUTY]: {[0]: 'critical', [1]: 'warning'},
	[ActionType.OPSGENIE]: {[0]: 'P1', [1]: 'P2'},
	export const DefaultPriorities: Record<ActionType, string[]> = {
	[ActionType.PAGERDUTY]: ['critical', 'warning'],
	[ActionType.OPSGENIE]: ['P1', 'P2'],