feat(ddm): Add custom_metrics_access organization flag #66953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- Alter field flags on organization
--
-- (no-op) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66953 +/- ##
=======================================
Coverage 84.31% 84.32%
=======================================
Files 5309 5309
Lines 237399 237405 +6
Branches 41058 41060 +2
=======================================
+ Hits 200172 200185 +13
+ Misses 37009 37002 -7
Partials 218 218
|
iambriccardo
force-pushed
the
riccardo/feat/add-org-flag
branch
from
e529721
to
8054d8c
Compare
iambriccardo
commented
Mar 14, 2024
| @@ -431,6 +432,10 @@ def save(self): | |||
| org.flags.codecov_access = data["codecovAccess"] | |||
| if "require2FA" in data: | |||
| org.flags.require_2fa = data["require2FA"] | |||
| # This option is temporary since we will control custom metrics via a single feature flag in the future. This | |||
There was a problem hiding this comment.
Right now, to enable custom metrics you have to activate:
"organizations:custom-metrics"
"organizations:ddm-ui"
"organizations:metrics-blocking"
"organizations:use-metrics-layer-in-alerts"
The role of this organization option is that it will be read by getsentry and it will enable all of those flags automatically in case the option was set to true. On self-hosted this org option will not be needed and rather the aforementioned flags will have to be activated manually.
obostjancic
approved these changes
Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new organization flag called
sentry:custom_metrics_accesswhich will be used internally bygetsentryto enable certain feature flags needed by custom metrics.