feat(pagerduty): issue alert custom severity #67158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #67158 +/- ##
=======================================
Coverage 84.31% 84.32%
=======================================
Files 5306 5306
Lines 237081 237122 +41
Branches 41001 41010 +9
=======================================
+ Hits 199906 199952 +46
+ Misses 36957 36952 -5
Partials 218 218
|
cathteng
commented
Mar 18, 2024
vartec
approved these changes
Mar 18, 2024
| @@ -14,6 +14,8 @@ | |||
| "error": "error", | |||
| "fatal": "critical", | |||
| } | |||
| PAGERDUTY_DEFAULT_PRIORITY = "default" # represents using LEVEL_SEVERITY_MAP | |||
| PagerdutyPriority = Literal["default", "critical", "warning", "error", "info"] | |||
Co-authored-by: Bartek Ogryczak <bartek.ogryczak@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting custom severity for Pagerduty actions for issue alerts.
Essentially copies the Opsgenie implementation of custom issue alert priorities #56140
Default severity utilizes the existing
LEVEL_SEVERITY_MAP:sentry/src/sentry/integrations/pagerduty/client.py
Lines 10 to 16 in c72814c
For #54921