fix: set scope_id property for project scoped abuse quota

[ministicraft]

The get_usage() function in RedisQuota doesn't return the AbuseQuota usage for project because QuotaConfig lack the scope_id properties

This result in incorrect generation of the quota redis_key

Current generated redis key:
quota:pae{1}:xxxxxxxx
Should be like:
quota:pae{1}2:xxxxxxxx

This PR set the scope_id in QuotaConfig for project scoped abuse quota with the current project id when getting it's quotas

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

[Dav1dde]

Thanks, good find!

I will double check back with my team, but I think we need to fix the Redis Key creation, to also consider the project scope:

sentry/src/sentry/quotas/redis.py

Lines 55 to 61 in 7727e3b

	def __get_redis_key(
	self, quota: QuotaConfig, timestamp: float, shift: int, organization_id: int
	) -> str:
	scope_id = quota.scope_id or "" if quota.scope != QuotaScope.ORGANIZATION else ""
	local_key = f"{quota.id}{{{organization_id}}}{scope_id}"
	interval = quota.window
	return f"{self.namespace}:{local_key}:{int((timestamp - shift) // interval)}"

[Dav1dde]

Sorry for the late reply, I was away over easter. So the fix we need for this is to sync the __get_redis_key implementation with the one in Relay: https://github.com/getsentry/relay/blob/7828241ba8c8d781e89e593c7c3609d50190c4a6/relay-quotas/src/redis.rs#L130-L150

I think for a simple initial fix, adding in code for the project scope would be enough (as there is already for orgs), but for total completeness we'd also need to consider the namespace.

[getsantry]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀