perf(nodestore): disable setting cache on write #68439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
anonrig
force-pushed
the
anonrig/disable-set-cache-nodestore
branch
from
29c7824
to
e213403
Compare
mitsuhiko
requested changes
Apr 8, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
anonrig
force-pushed
the
anonrig/disable-set-cache-nodestore
branch
from
e213403
to
50721c1
Compare
anonrig
force-pushed
the
anonrig/disable-set-cache-nodestore
branch
from
50721c1
to
f5c899f
Compare
mitsuhiko
approved these changes
Apr 8, 2024
anonrig
force-pushed
the
anonrig/disable-set-cache-nodestore
branch
from
f5c899f
to
ab70a89
Compare
anonrig
force-pushed
the
anonrig/disable-set-cache-nodestore
branch
from
ab70a89
to
33a6e81
Compare
shellmayr
pushed a commit
that referenced
this pull request
Apr 10, 2024
We are setting cache on every transaction, but not always reading it. This optimization would move the setting cache operation to `read`. I've moved the `set_cache_item` call inside an option `nodestore.set_subkeys.enable_set_cache_item` in case we need to revert this. Ref: getsentry/team-processing#135 cc @getsentry/processing
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are setting cache on every transaction, but not always reading it. This optimization would move the setting cache operation to
read.I've moved the
set_cache_itemcall inside an optionnodestore.set_subkeys.enable_set_cache_itemin case we need to revert this.Ref: https://github.com/getsentry/team-processing/issues/135
cc @getsentry/processing