Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): Persist has-viewed state to the server when replays are seen #68743

Merged
merged 3 commits into from Apr 15, 2024
Merged

feat(replay): Persist has-viewed state to the server when replays are seen #68743

merged 3 commits into from Apr 15, 2024

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Apr 11, 2024

@ryan953 ryan953 requested a review from a team as a code owner April 11, 2024 21:06
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 11, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited

Bundle Report

Changes will increase total bundle size by 1.04kB ⬆️

Bundle name Size Change
sentry-webpack-bundle-array-push 26.3MB 1.04kB ⬆️

@ryan953 ryan953 requested a review from a team as a code owner April 11, 2024 22:03
@ryan953 ryan953 mentioned this pull request Apr 11, 2024
Merged
@ryan953 ryan953 merged commit b0a33ce into master Apr 15, 2024
41 checks passed
@ryan953 ryan953 deleted the ryan953/64924-track-replay-viewed-by branch April 15, 2024 17:30
@ryan953 ryan953 added the Trigger: Revert add to a merged PR to revert it (skips CI) label Apr 15, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: ad31226

getsentry-bot added a commit that referenced this pull request Apr 15, 2024
@getsentry-bot @ryan953
Revert "feat(replay): Persist has-viewed state to the server when rep…
ad31226 
…lays are seen (#68743)"

This reverts commit b0a33ce.

Co-authored-by: ryan953 <187460+ryan953@users.noreply.github.com>
ryan953 added a commit that referenced this pull request Apr 16, 2024
@ryan953
feat(replay): Persist has-viewed state to the server when replays are…
6855896 
… seen (#68743)

Depends on #67951

Relates to getsentry/team-replay#19
Relates to #64924
@ryan953 ryan953 mentioned this pull request Apr 16, 2024
Merged
ryan953 added a commit that referenced this pull request Apr 16, 2024
@ryan953
feat(replay): Persist has-viewed state to the server when replays are…
1a17eae 
… seen (#68990)

This is a dupe of #68743, but
with a feature-flag wrapping it.

Depends on #67951

Relates to getsentry/team-replay#19
Relates to #64924
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michellewzhang michellewzhang michellewzhang approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryan953 @getsentry-bot @michellewzhang