Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feature): Clean up released features that use OptionBackedRolloutFeatureHandler in getsentry #69168

Merged
merged 2 commits into from Apr 18, 2024

Conversation

wedamija
Copy link
Member

I want to consolidate code between OptionBackedRolloutFeatureHandler and AutoRegisterOptionBackedRolloutFeatureHandler. These features handlers all use OptionBackedRolloutFeatureHandler, but have been released for months (https://redash.getsentry.net/queries/6524/source). Just removing the flags.

…outFeatureHandler` in getsentry

I want to consolidate code between `OptionBackedRolloutFeatureHandler` and `AutoRegisterOptionBackedRolloutFeatureHandler`. These features handlers all use `OptionBackedRolloutFeatureHandler`, but have been released for months (https://redash.getsentry.net/queries/6524/source). Just removing the flags.
@wedamija wedamija requested review from a team as code owners April 17, 2024 23:30
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 17, 2024
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.70%. Comparing base (fe86a58) to head (ea92f0c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #69168   +/-   ##
=======================================
  Coverage   79.70%   79.70%           
=======================================
  Files        6421     6421           
  Lines      285319   285306   -13     
  Branches    49161    49161           
=======================================
- Hits       227416   227406   -10     
+ Misses      57467    57464    -3     
  Partials      436      436           
Files Coverage Δ
src/sentry/conf/server.py 89.22% <ø> (ø)
src/sentry/features/temporary.py 100.00% <ø> (ø)
...rmance_issues/detectors/consecutive_db_detector.py 96.89% <100.00%> (-0.03%) ⬇️
...ormance_issues/detectors/http_overhead_detector.py 96.84% <100.00%> (-0.04%) ⬇️
...e_issues/detectors/mn_plus_one_db_span_detector.py 97.16% <100.00%> (-0.02%) ⬇️
..._issues/detectors/n_plus_one_api_calls_detector.py 93.37% <100.00%> (-0.05%) ⬇️
...s/detectors/render_blocking_asset_span_detector.py 96.10% <100.00%> (-0.05%) ⬇️
...ormance_issues/detectors/slow_db_query_detector.py 98.24% <100.00%> (-0.04%) ⬇️
...ce_issues/detectors/uncompressed_asset_detector.py 94.20% <100.00%> (-0.09%) ⬇️

... and 4 files with indirect coverage changes

@wedamija wedamija merged commit 3b2015a into master Apr 18, 2024
49 checks passed
@wedamija wedamija deleted the danf/cleanup-options-backed-features branch April 18, 2024 15:39
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants