-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): Add functions to query metrics meta tables #69803
Conversation
Generic metrics now have tables that store meta data about the metrics, notably the unique metric IDs, tag keys and tag values for any data received. This adds functions to query those tables and return the relevant values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thanks so much!
@@ -519,3 +530,159 @@ def convert_snuba_result( | |||
if reverse_resolve: | |||
data_point[key] = reverse_resolve | |||
return snuba_result | |||
|
|||
|
|||
def fetch_metric_mris( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to return the project_id
-> [MRI]
mapping? Since we use this information in our endpoints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can change that.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Generic metrics now have tables that store meta data about the metrics, notably
the unique metric IDs, tag keys and tag values for any data received.
This adds functions to query those tables and return the relevant values.
Depends on getsentry/snuba#5824