chore(superuser): use option for read-write instead of FF #70083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
commented
May 1, 2024
Comment on lines
+84
to
+87
| and ( | ||
| options.get("superuser.read-write.ga-rollout") | ||
| or features.has("auth:enterprise-superuser-read-write", actor=user) | ||
| ) |
There was a problem hiding this comment.
will be replacing logic like this with just the option later
cathteng
commented
May 1, 2024
Comment on lines
+114
to
+117
| if not ( | ||
| features.has("auth:enterprise-superuser-read-write", actor=request.user) | ||
| or options.get("superuser.read-write.ga-rollout") | ||
| ): |
There was a problem hiding this comment.
this is the only other code change besides adding the option, everything else is modifying test decorators
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70083 +/- ##
===========================================
+ Coverage 62.92% 79.83% +16.90%
===========================================
Files 6496 6502 +6
Lines 288948 289236 +288
Branches 49777 49810 +33
===========================================
+ Hits 181821 230907 +49086
+ Misses 106710 57918 -48792
+ Partials 417 411 -6
|
schew2381
approved these changes
May 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of replacing the superuser read-write feature flag with an option. There's code in getsentry that is using the flag, so we can't completely remove it yet.
The flag is not currently turned on, so using an OR for either the option or the flag for the logic is fine. This will be temporary.