ref(rules): Don't fire delayed rules if they're snoozed #70203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
saponifi3d
reviewed
May 6, 2024
| parsed_rulegroup_to_event_data = parse_rulegroup_to_event_data(rulegroup_to_event_data) | ||
|
|
||
| snoozed_rules = RuleSnooze.objects.filter( |
There was a problem hiding this comment.
thoughts on moving this condition to step 3? I was thinking it if we filter the snoozed alert rules there (around line 272) it would mean we don't have to process the alerts in the other steps as well.
wedamija
approved these changes
May 7, 2024
Comment on lines
+273
to
+275
| snoozed_rules = RuleSnooze.objects.filter(rule__in=alert_rules, user_id=None).values_list( | ||
| "rule", flat=True | ||
| ) |
There was a problem hiding this comment.
Nit: Let's convert this to a set?
There was a problem hiding this comment.
I'm about to do follow ups in this file so I'll change it there!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #69830 (comment) to check the
RuleSnoozetable before firing a delayed rule, on the off chance it got muted in the < 1 minute it took to process.Closes https://github.com/getsentry/team-core-product-foundations/issues/307