feat(perf): Update the Spans tab in Transaction Summary #70373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
0Calories
force-pushed
the
feat/new-spans-tab
branch
from
ebccc0a
to
032d8a8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #70373 +/- ##
==========================================
- Coverage 77.86% 77.86% -0.01%
==========================================
Files 6534 6536 +2
Lines 291150 291210 +60
Branches 50379 50383 +4
==========================================
+ Hits 226695 226738 +43
- Misses 58222 58239 +17
Partials 6233 6233
|
… feat/new-spans-tab
shruthilayaj
approved these changes
May 28, 2024
| | SpanMetricsField.SPAN_DESCRIPTION | ||
| | 'spm()' | ||
| | `avg(${SpanMetricsField.SPAN_DURATION})` | ||
| | `sum(${SpanMetricsField.SPAN_SELF_TIME})`; |
There was a problem hiding this comment.
We might have to move away from self_time Ash (can be done in a follow up) - let's talk to Ben
| const spanOp = decodeScalar(location.query?.spanOp); | ||
|
|
||
| const filters: SpanMetricsQueryFilters = { | ||
| transaction: transactionName, |
There was a problem hiding this comment.
should this also include transaction op and http op filters?
There was a problem hiding this comment.
I'll add this in a followup PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the
Spanstab on the transaction summary to query from the Span metrics dataset and changes the table to have columns more relevant to span metrics.Before
After
TODO in followup PRs