-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(seer grouping): Stop sending/receiving group id when communicating with Seer #70396
Merged
lobsterkatie
merged 10 commits into
master
from
kmclb-remove-group-id-handling-with-seer
May 20, 2024
Merged
ref(seer grouping): Stop sending/receiving group id when communicating with Seer #70396
lobsterkatie
merged 10 commits into
master
from
kmclb-remove-group-id-handling-with-seer
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
May 6, 2024
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 6, 2024 23:38
68d698e
to
9e73117
Compare
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 7, 2024 01:36
9e73117
to
1a45b4f
Compare
lobsterkatie
force-pushed
the
kmclb-rename-seer-hash-values
branch
from
May 7, 2024 16:04
32f707e
to
5567d64
Compare
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 7, 2024 16:09
1a45b4f
to
513a02c
Compare
lobsterkatie
force-pushed
the
kmclb-rename-seer-hash-values
branch
from
May 7, 2024 17:39
5567d64
to
c75b67d
Compare
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 7, 2024 17:40
513a02c
to
17518ab
Compare
lobsterkatie
force-pushed
the
kmclb-rename-seer-hash-values
branch
from
May 7, 2024 21:27
c75b67d
to
4b274bb
Compare
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 7, 2024 21:28
17518ab
to
c609237
Compare
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 8, 2024 02:22
c609237
to
67d1494
Compare
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 8, 2024 21:05
67d1494
to
a045038
Compare
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 9, 2024 18:48
a045038
to
bbce292
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70396 +/- ##
=======================================
Coverage 77.88% 77.88%
=======================================
Files 6528 6528
Lines 290835 290824 -11
Branches 50338 50335 -3
=======================================
- Hits 226518 226510 -8
+ Misses 58070 58065 -5
- Partials 6247 6249 +2
|
jangjodi
approved these changes
May 13, 2024
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 17, 2024 20:23
bbce292
to
13af859
Compare
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 17, 2024 20:43
13af859
to
e462e28
Compare
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 17, 2024 21:37
e462e28
to
b8a7c06
Compare
lobsterkatie
force-pushed
the
kmclb-remove-group-id-handling-with-seer
branch
from
May 17, 2024 21:54
b8a7c06
to
e4f5880
Compare
cmanallen
pushed a commit
that referenced
this pull request
May 21, 2024
…g with Seer (#70396) Now that Seer has stopped expecting group ids (we started sending the hash in addition to group id in #70244, and seer switched to handling hash rather than group id in getsentry/seer#625), and has stopped sending them back (also changed in getsentry/seer#625), we can close the loop and stop sending or expecting them on the Sentry side, too. This PR makes that change, which allows for some simplification in three places: - In the `SimilarIssuesEmbeddingsRequest` and `RawSeerSimilarIssueData` types, `group_id` and `parent_group_id` (respectively) are removed and `hash` and `parent_hash` (respectively) are no longer optional. - In `SeerSimilarIssueData.from_raw`, we no longer have to play the "Did Seer send back parent hash or parent group id?" game, and can instead just trust that the parent hash will be there and process it. - In `GroupSimilarIssuesEmbeddingsEndpoint.get_formatted_results`, we no longer have to handle the case of there being parent group ids in the passed data which correspond to non-existent groups, since the group ids there are no longer coming from Seer but from us, which gives us the opportunity to make sure they're real before passing them on. (Technically this could/should have happened in #70240, but better late than never.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Seer has stopped expecting group ids (we started sending the hash in addition to group id in #70244, and seer switched to handling hash rather than group id in https://github.com/getsentry/seer/pull/625), and has stopped sending them back (also changed in https://github.com/getsentry/seer/pull/625), we can close the loop and stop sending or expecting them on the Sentry side, too.
This PR makes that change, which allows for some simplification in three places:
In the
SimilarIssuesEmbeddingsRequest
andRawSeerSimilarIssueData
types,group_id
andparent_group_id
(respectively) are removed andhash
andparent_hash
(respectively) are no longer optional.In
SeerSimilarIssueData.from_raw
, we no longer have to play the "Did Seer send back parent hash or parent group id?" game, and can instead just trust that the parent hash will be there and process it.In
GroupSimilarIssuesEmbeddingsEndpoint.get_formatted_results
, we no longer have to handle the case of there being parent group ids in the passed data which correspond to non-existent groups, since the group ids there are no longer coming from Seer but from us, which gives us the opportunity to make sure they're real before passing them on. (Technically this could/should have happened in ref(seer-grouping): Automatically convertRawSeerSimilarIssueData
intoSeerSimilarIssueData
#70240, but better late than never.)