-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(feedback): consolidate all settings into one heading under project #70679
Conversation
@@ -30,7 +30,7 @@ function ProjectReplaySettings({organization, project, params: {projectId}}: Pro | |||
external | |||
href="https://docs.sentry.io/product/session-replay/replay-page-and-filters/" | |||
> | |||
{t('Read the docs')} | |||
{t('Read the Docs')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra change because this was inconsistent with other header actions in the settings, which all have the first word capitalized
Slightly unrelated but I'm almost certain the "Show Sentry branding" is for the Crash-Report modal specifically. Lets also update the copy for that while we're at it? |
64245f4
to
2406fa2
Compare
gap: ${space(1)}; | ||
`; | ||
|
||
export default withOrganization(ProjectUserFeedback); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is withOrganization
HoC still the preferred method of getting org from context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, i know we've been getting rid of some of them but i didn't want to mess with it here
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
closes #70663
as a fun bonus, this is also a deprecated async conversion so ref https://github.com/getsentry/frontend-tsc/issues/2
Before, we had two User Feedback headings in project settings, one under Processing (for spam detection) and one under SDK Setup (for crash report alerting options):
This PR moves all 3 settings into one User Feedback header under the main Project heading: