ref(delayed rules): Add instrumentation #70693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
saponifi3d
approved these changes
May 13, 2024
| logger.info( | ||
| "delayed_processing.last_active", | ||
| extra={"last_active": status.last_active, "freq_offset": freq_offset}, | ||
| with metrics.timer("delayed_processing.fire_rules.duration"): |
There was a problem hiding this comment.
just so i can understand, what's the difference between a timer and a span in these cases? is one better than the other?
There was a problem hiding this comment.
I think it's just sentry vs datadog
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instrumentation and logging to the delayed rule processor to measure how long the bulkier functions are taking and how many rules and groups we're processing.
Closes https://getsentry.atlassian.net/browse/ALRT-19 and https://github.com/getsentry/team-core-product-foundations/issues/308 (a dupe) as a follow up to #69830 (review)