Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: move more implementations to use orjson #70832

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented May 14, 2024

Moves more implementations to use orjson

Ref: #68903

@anonrig anonrig requested review from a team as code owners May 14, 2024 00:42
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 14, 2024
Copy link
Member

@iamrajjoshi iamrajjoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 for my knowledge: what benefits do we get by switching?

@anonrig
Copy link
Member Author

anonrig commented May 14, 2024

🚀 for my knowledge: what benefits do we get by switching?

@iamrajjoshi I forgot the reference for the original issue: #68903. To summarize, performance and JSON specification compliance :-)

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 80.00%. Comparing base (4b1e575) to head (cf773ce).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #70832   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files        6507     6507           
  Lines      290833   290855   +22     
  Branches    50123    50131    +8     
=======================================
+ Hits       232686   232705   +19     
- Misses      57711    57714    +3     
  Partials      436      436           
Files Coverage Δ
src/sentry/conf/locale.py 100.00% <100.00%> (ø)
src/sentry/data_export/models.py 99.00% <100.00%> (ø)
src/sentry/hybridcloud/tasks/deliver_webhooks.py 96.39% <100.00%> (+0.01%) ⬆️
src/sentry/identity/gitlab/provider.py 82.75% <100.00%> (ø)
src/sentry/identity/vsts/provider.py 85.96% <100.00%> (ø)
src/sentry/incidents/action_handlers.py 91.30% <100.00%> (ø)
src/sentry/mail/notifications.py 97.29% <100.00%> (ø)
src/sentry/testutils/factories.py 96.00% <100.00%> (+<0.01%) ⬆️
src/sentry/identity/google/provider.py 48.48% <50.00%> (ø)
src/sentry/identity/oauth2.py 87.63% <80.00%> (ø)
... and 2 more

... and 6 files with indirect coverage changes

@anonrig anonrig merged commit 6c80b1e into master May 14, 2024
50 of 51 checks passed
@anonrig anonrig deleted the anonrig/move-more-json branch May 14, 2024 03:27
Copy link

sentry-io bot commented May 18, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ JSONDecodeError: byte order mark (BOM) is not supported: line 1 column 1 (char 0) /identity/login/{provider}/ View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants