Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(staff): Prevent fetching authenticators before preloading #70938

Merged
merged 1 commit into from
May 15, 2024
Merged

fix(staff): Prevent fetching authenticators before preloading #70938

merged 1 commit into from
May 15, 2024

Conversation

schew2381
Copy link
Member

@schew2381 schew2381 commented May 15, 2024 •
edited

There may be one more place in projects where we preload, but I want to check if this will work first.

@schew2381 schew2381 requested review from saponifi3d, cathteng and a team May 15, 2024 13:41
@schew2381 schew2381 self-assigned this May 15, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 15, 2024
@codecov Codecov
Copy link

codecov bot commented May 15, 2024

Bundle Report

Changes will decrease total bundle size by 52.08kB ⬇️

Bundle name Size Change
app-webpack-bundle-array-push 26.75MB 52.08kB ⬇️

@schew2381 schew2381 merged commit 8e8095a into master May 15, 2024
44 checks passed
@schew2381 schew2381 deleted the seiji/fix/prevent-loading-authenticators-before-preload-requests-finish branch May 15, 2024 13:58
iamrajjoshi added a commit that referenced this pull request May 15, 2024
@iamrajjoshi
Revert "fix(staff): Prevent fetching authenticators before preloading (…
3d9c9e6 
…#70938)"

This reverts commit 8e8095a.
@iamrajjoshi iamrajjoshi mentioned this pull request May 15, 2024
Closed
@sentaur-athena sentaur-athena added the Trigger: Revert add to a merged PR to revert it (skips CI) label May 15, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 2d7dcff

getsentry-bot added a commit that referenced this pull request May 15, 2024
@getsentry-bot @sentaur-athena
Revert "fix(staff): Prevent fetching authenticators before preloading (…
2d7dcff 
…#70938)"

This reverts commit 8e8095a.

Co-authored-by: sentaur-athena <132939361+sentaur-athena@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iamrajjoshi iamrajjoshi iamrajjoshi approved these changes

@saponifi3d saponifi3d Awaiting requested review from saponifi3d

@cathteng cathteng Awaiting requested review from cathteng

Assignees

@schew2381 schew2381

Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schew2381 @getsentry-bot @iamrajjoshi @sentaur-athena