ref(insights): move sample panel open tracking to panel onOpen #70982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
KevinL10
changed the title
narsaynorath
approved these changes
May 16, 2024
There was a problem hiding this comment.
I noticed there's still a starfish.panel.open event in two places that I think we should remove (i.e. the call sites and even the event definition) since the analytics you're adding are better. Let me know if you want to do that, or I could throw up a PR after this is merged.
KevinL10
force-pushed
the
kevinliu/feat/sample-panel-onopen-analytics
branch
from
1c676f5
to
44378d7
Compare
|
I'll take out the outdated starfish analytics |
Bundle ReportChanges will decrease total bundle size by 225 bytes ⬇️
|
cmanallen
pushed a commit
that referenced
this pull request
May 21, 2024
Track `performance_views.sample_spans.opened` on `<DetailPanel
onOpen={...}>` instead of tracking the table clicks that trigger the
sample span popup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track
performance_views.sample_spans.openedon<DetailPanel onOpen={...}>instead of tracking the table clicks that trigger the sample span popup.