feat(new-trace): Sorting trace drawer card content by subject.

[Abdkhan14]

No description provided.

[JonasBa]

Suggested change

	enableSorting
	sortAlphabetically

[JonasBa]

I'm going to wait for others to review as we dont own this code. Besides the prop name change, the changes look fine to me

[leeandher]

This will alter the order for context on issues details page as well. I preserved that order because it was what was there before, but I don't see a reason why we can't change it. Alphabetically seems good to me 👍 -- more of an FYI

[Abdkhan14]

Heyo @leeandher, it only changes the order of the items inside the card. The context ordering is one level above this, it won't change.

[JonasBa]

@Abdkhan14 .sort mutates the original array, so this might in fact change the order. It would be safer to create a copy of contextItems before sorting

[leeandher]

Oh I see, either way that order was also intentional. It displays the known items for each context before any additional items the user added from their SDK.

[Abdkhan14]

Noted @leeandher, lets give sorting alphabetically a go.

[Abdkhan14]

@Abdkhan14 .sort mutates the original array, so this might in fact change the order. It would be safer to create a copy of contextItems before sorting

@JonasBa, he mentioned the ordering of cards. We are sorting card > items.

[leeandher]

Code looks good, but are there any instances that don't get receive sortAlphabetically = true? If not, you can probably skip the prop and just apply the sort for all renders of SectionCard

[Abdkhan14]

Code looks good, but are there any instances that don't get receive sortAlphabetically = true? If not, you can probably skip the prop and just apply the sort for all renders of SectionCard

Yeah we don't sort the general Info sections.