Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-alert): Update Query to use Org & Project Filtering for Release Health #71386

Closed

Conversation

iamrajjoshi
Copy link
Member

Helps mitigate https://getsentry.atlassian.net/browse/ISSUE-1702

I create an option to query switch between the old query and the new query.

The new query is the same as old query p much, but with few differences. we sort by org_id and project_id and use the last one as the filter for the next query.

@iamrajjoshi iamrajjoshi self-assigned this May 22, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 22, 2024
UseCaseID.SESSIONS, org_id, SessionMRI.RAW_SESSION.value
),
),
Condition(Column("org_id"), Op.GTE, prev_org_id),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not have processed all the projects for an org.

@iamrajjoshi iamrajjoshi requested a review from wedamija May 22, 2024 19:58
@iamrajjoshi iamrajjoshi marked this pull request as ready for review May 22, 2024 19:58
@iamrajjoshi iamrajjoshi requested a review from a team May 22, 2024 20:02
@iamrajjoshi iamrajjoshi changed the title fix(release-alert): Update Query to use Org & Project Filtering fix(release-alert): Update Query to use Org & Project Filtering for Release Health May 22, 2024
@iamrajjoshi iamrajjoshi force-pushed the raj/fix/release-alert/use-filter-instead-of-offset branch from 06b402f to 20aee36 Compare May 23, 2024 13:27
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 83.72093% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (50207c0) to head (9f631e5).
Report is 1000 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #71386   +/-   ##
=======================================
  Coverage   77.87%   77.87%           
=======================================
  Files        6538     6538           
  Lines      291235   291277   +42     
  Branches    50391    50400    +9     
=======================================
+ Hits       226809   226845   +36     
  Misses      58187    58187           
- Partials     6239     6245    +6     
Files Coverage Δ
...c/sentry/release_health/release_monitor/metrics.py 83.80% <83.72%> (-0.20%) ⬇️

... and 4 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Jun 14, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jun 14, 2024
@iamrajjoshi
Copy link
Member Author

@wedamija if we don't want/need to do this, i can close this PR

@getsantry getsantry bot closed this Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant