Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-consumer): make batched parallel mode default #71572

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

scefali
Copy link
Contributor

@scefali scefali commented May 28, 2024

Making batched-parallel mode default now that it has been rolled out in all env

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 28, 2024
@scefali scefali marked this pull request as ready for review May 28, 2024 17:30
@scefali scefali requested review from a team as code owners May 28, 2024 17:30
@scefali scefali requested a review from lynnagara May 28, 2024 17:30
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (358ea57) to head (aa65aff).
Report is 1063 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #71572      +/-   ##
==========================================
+ Coverage   77.90%   77.91%   +0.01%     
==========================================
  Files        6552     6552              
  Lines      291858   291427     -431     
  Branches    50438    50412      -26     
==========================================
- Hits       227365   227061     -304     
+ Misses      58237    58116     -121     
+ Partials     6256     6250       -6     
Files Coverage Δ
src/sentry/consumers/__init__.py 78.94% <ø> (ø)

... and 266 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Jun 19, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jun 19, 2024
@scefali
Copy link
Contributor Author

scefali commented Jun 23, 2024

@snigdhas has the feature stabilized yet? Can this be merged?

@snigdhas
Copy link
Member

Hey @scefali, not yet - @vartec might have more context here

@snigdhas snigdhas removed the Stale label Jun 25, 2024
@vartec
Copy link
Member

vartec commented Jun 25, 2024

Hey @scefali, not yet - @vartec might have more context here

I'm about to GA change that re-orders and collapses status changes (#72570). As far as I understand that was the thing blocking landing this PR.

@vartec vartec merged commit c730732 into master Jun 25, 2024
52 checks passed
@vartec vartec deleted the feat/make-batched-parallel-mode-default branch June 25, 2024 20:21
@vartec
Copy link
Member

vartec commented Jun 25, 2024

Working great. Thank you @scefali!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants