-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(querybuilder): Clean up the way we load configs #71710
Conversation
wmak
commented
May 29, 2024
- Instead of a giant if statement for every dataset in the base query builder, set the config in a load config function in each builder
- Instead of a giant if statement for every dataset in the base query builder, set the config in a load config function in each builder
- Also throw a better error if parse isn't called
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71710 +/- ##
==========================================
- Coverage 78.01% 78.00% -0.01%
==========================================
Files 6630 6632 +2
Lines 295916 296055 +139
Branches 50971 50988 +17
==========================================
+ Hits 230848 230938 +90
- Misses 58732 58780 +48
- Partials 6336 6337 +1
|