Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(querybuilder): Clean up the way we load configs #71710

Merged
merged 16 commits into from
Jun 25, 2024

Conversation

wmak
Copy link
Member

@wmak wmak commented May 29, 2024

  • Instead of a giant if statement for every dataset in the base query builder, set the config in a load config function in each builder

- Instead of a giant if statement for every dataset in the base query
  builder, set the config in a load config function in each builder
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 29, 2024
- Also throw a better error if parse isn't called
@getsantry
Copy link
Contributor

getsantry bot commented Jun 21, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.00%. Comparing base (486a589) to head (ab28d60).
Report is 54 commits behind head on master.

Current head ab28d60 differs from pull request most recent head 823c6bc

Please upload reports for the commit 823c6bc to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #71710      +/-   ##
==========================================
- Coverage   78.01%   78.00%   -0.01%     
==========================================
  Files        6630     6632       +2     
  Lines      295916   296055     +139     
  Branches    50971    50988      +17     
==========================================
+ Hits       230848   230938      +90     
- Misses      58732    58780      +48     
- Partials     6336     6337       +1     
Files Coverage Δ
src/sentry/search/events/builder/metrics.py 88.51% <100.00%> (+0.16%) ⬆️
.../sentry/search/events/builder/metrics_summaries.py 85.71% <100.00%> (+2.38%) ⬆️
.../sentry/search/events/builder/profile_functions.py 89.88% <100.00%> (+0.35%) ⬆️
...search/events/builder/profile_functions_metrics.py 83.33% <100.00%> (+1.51%) ⬆️
src/sentry/search/events/builder/sessions.py 87.09% <100.00%> (+0.88%) ⬆️
src/sentry/search/events/builder/spans_indexed.py 100.00% <100.00%> (ø)
src/sentry/search/events/builder/spans_metrics.py 100.00% <100.00%> (ø)
src/sentry/snuba/metrics/query_builder.py 90.35% <100.00%> (+0.03%) ⬆️
src/sentry/search/events/builder/discover.py 92.60% <88.88%> (-0.34%) ⬇️

... and 59 files with indirect coverage changes

@wmak wmak marked this pull request as ready for review June 25, 2024 16:03
@wmak wmak requested review from a team as code owners June 25, 2024 16:03
@wmak wmak merged commit 5aeaf13 into master Jun 25, 2024
48 checks passed
@wmak wmak deleted the wmak/ref/remove-giant-if-block-for-datasets branch June 25, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants