fix(environments): Fix stream view fetching too many times #7250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxBittker
reviewed
Feb 14, 2018
| @@ -531,6 +531,9 @@ const Stream = createReactClass({ | |||
| }, | |||
|
|
|||
| onLatestContextChange(context) { | |||
| // Don't do anything unless environment is changing | |||
| if (context.environment === this.state.activeEnvironment) return; | |||
There was a problem hiding this comment.
this implies that the only context change we care about ever is environment, is that true?
There was a problem hiding this comment.
Yep. In this view you can't modify project or organization so we don't have to listen for it (with the exception of starring the project and we want to ignore that)
lynnagara
changed the title
MaxBittker
approved these changes
Feb 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7243