-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sudo): Selectively log user email on superuser access #72611
Merged
+106
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can leak PII for users from orgs other than the staff org, per getsentry/team-core-product-foundations#315
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72611 +/- ##
==========================================
+ Coverage 78.00% 78.12% +0.11%
==========================================
Files 6635 6622 -13
Lines 296661 295659 -1002
Branches 51087 50931 -156
==========================================
- Hits 231416 230986 -430
+ Misses 58863 58383 -480
+ Partials 6382 6290 -92
|
Having found no good way to bind this to an actual auth provider, I've kludged in a single-purpose conf value that should do the trick. It should be pretty easy to refactor out again if anyone wants to take another pass later. |
sentaur-athena
approved these changes
Jun 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can leak PII for users from orgs other than the staff org, per https://github.com/getsentry/team-core-product-foundations/issues/315