Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(trace-explorer): Service Entry spans always have group 0 #72817

Merged
merged 3 commits into from
Jun 17, 2024
Merged

perf(trace-explorer): Service Entry spans always have group 0 #72817

merged 3 commits into from
Jun 17, 2024

Conversation

Zylphrex
Copy link
Member

Group is only computed for the spans for the various insights modules. Service entry spans always have a group of 0, so leverage that for optimization.

@Zylphrex
perf(trace-explorer): Service Entry spans always have group 0
ed9f1a5 
Group is only computed for the spans for the various insights modules. Service
entry spans always have a group of 0, so leverage that for optimization.
@Zylphrex Zylphrex requested a review from a team as a code owner June 14, 2024 20:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 14, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.05%. Comparing base (85ca774) to head (68aab8a).

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #72817       +/-   ##
===========================================
+ Coverage   56.97%   78.05%   +21.07%     
===========================================
  Files        6594     6604       +10     
  Lines      294123   294092       -31     
  Branches    50700    50712       +12     
===========================================
+ Hits       167575   229549    +61974     
+ Misses     121754    58304    -63450     
- Partials     4794     6239     +1445
Files Coverage Δ
src/sentry/api/endpoints/organization_traces.py 90.77% <100.00%> (+69.85%) ⬆️
src/sentry/search/events/constants.py 100.00% <ø> (ø)
src/sentry/sentry_metrics/querying/samples_list.py 93.95% <ø> (+66.95%) ⬆️

... and 2127 files with indirect coverage changes

@Zylphrex Zylphrex requested review from a team as code owners June 17, 2024 15:34
@Zylphrex Zylphrex enabled auto-merge (squash) June 17, 2024 15:35
@Zylphrex Zylphrex merged commit 0d4df7e into master Jun 17, 2024
49 checks passed
@Zylphrex Zylphrex deleted the txiao/perf/service-entry-spans-always-have-group-0 branch June 17, 2024 16:03
@Zylphrex Zylphrex added the Trigger: Revert add to a merged PR to revert it (skips CI) label Jun 18, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 9ebd80d

getsentry-bot added a commit that referenced this pull request Jun 18, 2024
@getsentry-bot @Zylphrex
Revert "perf(trace-explorer): Service Entry spans always have group 0 (…
9ebd80d 
…#72817)"

This reverts commit 0d4df7e.

Co-authored-by: Zylphrex <10239353+Zylphrex@users.noreply.github.com>
@Zylphrex
Copy link
Member Author

Reverting since this assumption seems to be false for http.server transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmak wmak wmak approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zylphrex @getsentry-bot @wmak