feat(slack): Show culprit in notifications

[iamrajjoshi]

Just wrapping @olagjo's PR #72587 around a FF so we can quickly turn it on/off.

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/integrations/slack/message_builder/issues.py

Function	Unhandled Issue
build	TypeError: 'NoneType' object cannot be interpreted as an integer sentry.tasks.activity.send_activi... Event Count: 7
build	Actor.InvalidActor: Cannot find a User with id=2493315 sentry.tasks.digests.deliver_... Event Count: 3

---

_{Did you find this useful? React with a 👍 or 👎}

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.04%. Comparing base (a741388) to head (b95b736).

❗ Current head b95b736 differs from pull request most recent head e0c0027

Please upload reports for the commit e0c0027 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #72980       +/-   ##
===========================================
+ Coverage   46.59%   78.04%   +31.45%     
===========================================
  Files        1873     6624     +4751     
  Lines      120667   295748   +175081     
  Branches    21721    50943    +29222     
===========================================
+ Hits        56224   230831   +174607     
+ Misses      63382    58621     -4761     
- Partials     1061     6296     +5235     

Files	Coverage Δ
src/sentry/features/temporary.py	100.00% <100.00%> (ø)
src/sentry/testutils/cases.py	85.76% <92.30%> (+54.86%)	⬆️
...entry/integrations/slack/message_builder/issues.py	85.39% <71.42%> (+67.10%)	⬆️

... and 6017 files with indirect coverage changes

[cathteng]

should we keep testing for slack messages without culprit? right now it seems like we've removed coverage for no culprit messages

[olagjo]

should we keep testing for slack messages without culprit? right now it seems like we've removed coverage for no culprit messages

There are still tests where there are no culprit blocks – however, in all of them it's currently because the feature flag is off.
We can turn the feature flag on on e.g.:
tests/sentry/integrations/slack/test_message_builder.py::BuildGroupAttachmentReplaysTest::test_build_replay_issue
Locally for me, this test still passes without outputting a culprit block, even with the feature flag on (and this should hopefully fix the coverage as well!)

[olagjo]

Yay!
Can we get this enabled on our organization hyreas? :D

[iamrajjoshi]

Yay! Can we get this enabled on our organization hyreas? :D

i added the org in the LA group!

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ KeyError: 'event_metadata' pytest.runtest.protocol tests/sentry/integratio... View Issue

_{Did you find this useful? React with a 👍 or 👎}