Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): Screen count data per release #73044

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jun 20, 2024

Show screen counts for app starts and screen loads per release.

Module Before After
App Starts CleanShot 2024-06-20 at 11 03 23@2x CleanShot 2024-06-20 at 11 02 47@2x
Screen Loads CleanShot 2024-06-20 at 11 04 33@2x CleanShot 2024-06-20 at 11 04 50@2x

Show screen counts for app starts and screen loads per release.
@philipphofmann philipphofmann requested a review from a team as a code owner June 20, 2024 09:05
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Bundle Report

Changes will increase total bundle size by 334 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.31MB 334 bytes ⬆️

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.98%. Comparing base (a21b015) to head (53f3c64).

Current head 53f3c64 differs from pull request most recent head de7d856

Please upload reports for the commit de7d856 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #73044       +/-   ##
===========================================
+ Coverage   61.35%   77.98%   +16.62%     
===========================================
  Files        6616     6616               
  Lines      295328   295321        -7     
  Branches    50864    50889       +25     
===========================================
+ Hits       181205   230299    +49094     
+ Misses     108428    58733    -49695     
- Partials     5695     6289      +594     
Files Coverage Δ
...ights/mobile/appStarts/views/screenSummaryPage.tsx 55.55% <ø> (-6.95%) ⬇️
...ts/mobile/screenload/views/screenLoadSpansPage.tsx 90.90% <100.00%> (+2.02%) ⬆️

... and 1991 files with indirect coverage changes

@philipphofmann philipphofmann enabled auto-merge (squash) June 21, 2024 08:23
@philipphofmann philipphofmann merged commit edd8089 into master Jun 21, 2024
41 checks passed
@philipphofmann philipphofmann deleted the feat/insights/screen-count-per-release branch June 21, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants