Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metrics): remove disabled featured flag #73101

Merged
merged 1 commit into from
Jun 21, 2024
Merged

chore(metrics): remove disabled featured flag #73101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions static/app/utils/metrics/features.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,8 @@ export function hasMetricsExperimentalFeature(organization: Organization) {
return organization.features.includes('custom-metrics-experimental');
}

export function hasMetricsSidebarItem(organization: Organization) {
return !organization.features.includes('ddm-sidebar-item-hidden');
}

export function hasCustomMetrics(organization: Organization) {
return (
organization.features.includes('custom-metrics') &&
hasMetricsSidebarItem(organization)
);
return organization.features.includes('custom-metrics');
}

export function hasMetricAlertFeature(organization: Organization) {
Expand Down
7 changes: 1 addition & 6 deletions static/app/views/dashboards/dashboard.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,12 +363,7 @@ describe('Dashboards > Dashboard', () => {
it('does not show the add widget button if dashboard is in preview mode', async function () {
const testData = initializeOrg({
organization: {
features: [
'dashboards-basic',
'dashboards-edit',
'custom-metrics',
'ddm-sidebar-item-hidden',
],
features: ['dashboards-basic', 'dashboards-edit', 'custom-metrics'],
},
});
const dashboardWithOneWidget = {
Expand Down
Loading