feat(trace-explorer): Experiment with sorting by timestamp #73119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an experiment to try supporting sorting traces by timestamp.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73119 +/- ##
===========================================
+ Coverage 56.91% 77.99% +21.07%
===========================================
Files 6611 6626 +15
Lines 295232 295748 +516
Branches 50848 50931 +83
===========================================
+ Hits 168026 230655 +62629
+ Misses 122482 58814 -63668
- Partials 4724 6279 +1555
|
k-fish
approved these changes
Jun 21, 2024
| limit=self.limit, | ||
| timestamp_column=timestamp_column, | ||
| max_execution_seconds=30, | ||
| max_parallel_queries=3, |
There was a problem hiding this comment.
Good call on parallel to speed it up a bit, are we sure this won't spam Snuba and hit rate limits?
There was a problem hiding this comment.
3 x 8 hour queries should stay within the rate limits of snuba but I'll confirm before merging. And I explicitly moved this to a different referrer to help alleviate this concern slightly.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to try supporting sorting traces by timestamp.