Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-lambda-integration): Fix require paths for the SDK #73267

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Jun 25, 2024

We set the wrong require paths: https://unpkg.com/browse/@sentry/aws-serverless@8.11.0/package.json (see ./awslambda-auto export)

@lforst lforst requested a review from a team as a code owner June 25, 2024 09:35
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 25, 2024
@lforst lforst closed this Jun 25, 2024
@lforst lforst reopened this Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.02%. Comparing base (0f3ec5f) to head (fc8ffb3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #73267   +/-   ##
=======================================
  Coverage   78.02%   78.02%           
=======================================
  Files        6633     6633           
  Lines      295982   295982           
  Branches    50970    50970           
=======================================
+ Hits       230933   230934    +1     
+ Misses      58717    58713    -4     
- Partials     6332     6335    +3     
Files Coverage Δ
src/sentry/integrations/aws_lambda/utils.py 87.09% <ø> (ø)

... and 10 files with indirect coverage changes

@lforst lforst merged commit b297d91 into master Jun 25, 2024
49 checks passed
@lforst lforst deleted the lforst-fix-lambda-path branch June 25, 2024 11:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants