Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(billing): Introduce Outcomes Dead Letter Queue type #73334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dashed
Copy link
Member

@dashed dashed commented Jun 25, 2024

Introduce Topic.OUTCOMES_DLQ to be used for the dead letter queue on the outcomes consumer.

@dashed dashed requested review from lynnagara and a team June 25, 2024 22:28
@dashed dashed self-assigned this Jun 25, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (5aeaf13) to head (a77f8ca).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #73334   +/-   ##
=======================================
  Coverage   78.01%   78.01%           
=======================================
  Files        6632     6632           
  Lines      296035   296124   +89     
  Branches    50986    50999   +13     
=======================================
+ Hits       230957   231028   +71     
- Misses      58794    58811   +17     
- Partials     6284     6285    +1     
Files Coverage Δ
src/sentry/conf/types/kafka_definition.py 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

Copy link
Member

@lynnagara lynnagara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but all topics need to have their configuration defined in https://github.com/getsentry/sentry-kafka-schemas before they can be used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants