Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(environments): Remove environment feature flag from alert rules #7346

Merged
merged 1 commit into from Feb 27, 2018
Merged

feat(environments): Remove environment feature flag from alert rules #7346

merged 1 commit into from Feb 27, 2018

Conversation

lynnagara
Copy link
Member

@lynnagara lynnagara commented Feb 22, 2018 •
edited

This should be safe for general release separate to the rest of the environments functionality

@ghost
Copy link

ghost commented Feb 22, 2018 •
edited by ghost

1 Warning
⚠️ You should update CHANGES due to the size of this PR

Generated by 🚫 danger

@lynnagara lynnagara requested a review from a team February 23, 2018 22:30
MaxBittker
MaxBittker approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@MaxBittker MaxBittker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the backend implications of letting people send this (and i'm scared since that empty string issue), but the actual diff looks correct to me 👍

@lynnagara lynnagara closed this Feb 26, 2018
@lynnagara lynnagara reopened this Feb 26, 2018
@lynnagara lynnagara merged commit e8ff7b5 into master Feb 27, 2018
@lynnagara lynnagara deleted the remove-flag-alert-rules branch February 27, 2018 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MaxBittker MaxBittker MaxBittker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lynnagara @MaxBittker