Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): rm unused post-process-group flag from test #74090

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Jul 10, 2024

No references anywhere else in sentry and getsentry

@aliu39 aliu39 requested a review from a team as a code owner July 10, 2024 18:57
@aliu39 aliu39 requested review from JoshFerge and removed request for a team July 10, 2024 18:57
@aliu39 aliu39 enabled auto-merge (squash) July 10, 2024 18:57
@aliu39 aliu39 requested a review from a team July 10, 2024 18:57
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double checking this isn't a flag used for the issue platform?

@aliu39
Copy link
Member Author

aliu39 commented Jul 10, 2024

Oops, looks like it is! Test passes without this flag though. Doesn't seem like we have post process tests

@aliu39 aliu39 disabled auto-merge July 10, 2024 19:05
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (bce0d31) to head (9c1ce21).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #74090       +/-   ##
===========================================
+ Coverage   66.77%   78.16%   +11.38%     
===========================================
  Files        6658     6660        +2     
  Lines      297542   297697      +155     
  Branches    51240    51268       +28     
===========================================
+ Hits       198692   232703    +34011     
+ Misses      92112    58729    -33383     
+ Partials     6738     6265      -473     

see 1658 files with indirect coverage changes

@aliu39
Copy link
Member Author

aliu39 commented Jul 10, 2024

@JoshFerge ok if I remove this reference? Or was there a reason we need it for this test?

@aliu39 aliu39 merged commit 40efdd7 into master Jul 10, 2024
48 checks passed
@aliu39 aliu39 deleted the aliu/flag-cleanup branch July 10, 2024 20:05
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants