chore(slack): remove old client from webhook handling code #74104
+103
−442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ykamo001
approved these changes
Jul 10, 2024
Comment on lines
+673
to
+679
| logger.info( | ||
| "slack.webhook.view_submission.success", | ||
| extra={ | ||
| "integration_id": slack_request.integration.id, | ||
| "blocks": json_blocks, | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Do we need the success log now that we're moving to enabled? Plus we have the metrics for it to monitor
| tags={"type": "submit_modal"}, | ||
| ) | ||
| logger.error( | ||
| "slack.webhook.view_submission.response-error", extra={"error": str(e)} |
There was a problem hiding this comment.
do we want to log more information to help with debugging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the old slack client completely from Slack code that handles updating a group, specifically removing from the code the processes updates from the archive and resolve modals (and updates the Slack message).
Also adds metrics for all of the group update code in Slack, we also have another place in the same function that updates the Slack message for group updates not through the modal (e.g. mark the issue as ongoing)