fix(2fa): Send 'security settings changed' email with 2fa enroll #8771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -195,7 +195,7 @@ def post(self, request, user, interface_id): | |||
| context={ | |||
| 'authenticator': interface.authenticator, | |||
| }, | |||
| send_email=False, | |||
| send_email=True, | |||
There was a problem hiding this comment.
🤔 I wonder why we didn't do this to begin with.
billyvg
reviewed
Jun 20, 2018
| @@ -203,7 +214,10 @@ def test_recovery_codes_regenerate(self): | |||
| resp = self.client.get(url) | |||
| assert old_codes != resp.data['codes'] | |||
|
|
|||
| def test_delete(self): | |||
| assert email_log.info.call_count == 0 | |||
There was a problem hiding this comment.
Wouldn't we want this action to send an email?
There was a problem hiding this comment.
Ya, I'll add it in a follow-up pr ^
billyvg
reviewed
Jun 20, 2018
| @@ -155,6 +163,8 @@ def test_u2f_remove_device(self): | |||
| resp = self.client.delete(url) | |||
| assert resp.status_code == 500 | |||
|
|
|||
| assert email_log.info.call_count == 0 | |||
There was a problem hiding this comment.
Removing a device seems like it should generate an email as well
There was a problem hiding this comment.
Ya, I'll add it in a follow-up pr ^
billyvg
approved these changes
Jun 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.